[ENH] miscellaneous small changes and minor fixes #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR emcompasses a collection of smal minor enhancements and fixes.
1). When
dcm2niixorpet2bidserrors occur when the $root/list file is empty, these errors aren't displayed to users. Although rare, this can leads users to think ezBIDS couldn't detect their uploaded data, when in reality the problem lies with the data. This PR alerts users to this, so that they can reach to the dcm2niix team for assistance.2). There was a small bug where uploaded NIfTI files without corresponding metadata JSON file weren't being recognized and allowed. This is now fixed.
3). For
funcdatatype metadata checks where there's no corresponding metadata file, wasn't alerting users to the lack ofRepetitionTime.