Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added commonly user terms #718

Merged
merged 18 commits into from
Aug 12, 2023
Merged

Added commonly user terms #718

merged 18 commits into from
Aug 12, 2023

Conversation

wizard7377
Copy link
Contributor

Added a list of commonly used terms, not specific to D++ or C++, but rather to discord and bot development

@netlify
Copy link

netlify bot commented Jun 27, 2023

Deploy Preview for dpp-dev ready!

Name Link
🔨 Latest commit 805781b
🔍 Latest deploy log https://app.netlify.com/sites/dpp-dev/deploys/64d61fdc4e5ec20007d5d618
😎 Deploy Preview https://deploy-preview-718--dpp-dev.netlify.app/md_docpages_disdppgloss
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Andosius
Copy link
Contributor

You can use \ref clusters-shards-guilds in disdppgloss.md instead of the full url.
Not sure if you're still able to use ** on them tho

@Commandserver
Copy link
Member

Commandserver commented Jul 8, 2023

hmm. A table would fit more in my opinion

@braindigitalis
Copy link
Contributor

disdppgloss needs to be added to the spellcheck config in the root of the repository.

raxyte
raxyte previously requested changes Jul 9, 2023
docpages/disdppgloss.md Outdated Show resolved Hide resolved
docpages/disdppgloss.md Outdated Show resolved Hide resolved
docpages/disdppgloss.md Outdated Show resolved Hide resolved
@Commandserver Commandserver added documentation Improvements or additions to documentation good first issue Good for newcomers labels Jul 18, 2023
@braindigitalis
Copy link
Contributor

how is this progressing @wizard7377 ?

@braindigitalis
Copy link
Contributor

is this PR still alive at all?

Copy link
Member

@Commandserver Commandserver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great overall! just some formatting things i would change

docpages/disdppgloss.md Outdated Show resolved Hide resolved
docpages/disdppgloss.md Outdated Show resolved Hide resolved
Copy link
Contributor

@braindigitalis braindigitalis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you have too many commas, where instead you can use full stops and other punctuation, as it stands I feel a bit out of breath reading the document, can you please change the structure of the sentences to have less commas, so that it is manageable, did grammarly do that?

docpages/disdppgloss.md Outdated Show resolved Hide resolved
docpages/disdppgloss.md Outdated Show resolved Hide resolved
docpages/disdppgloss.md Outdated Show resolved Hide resolved
@braindigitalis braindigitalis dismissed raxyte’s stale review August 12, 2023 09:07

the issues raised are already resolved

@braindigitalis braindigitalis merged commit 4f1e4ee into brainboxdotcc:dev Aug 12, 2023
10 checks passed
@wizard7377 wizard7377 deleted the docs_change branch August 12, 2023 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants