Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Altered minimum gcc version for Coro, fixed docs issues #1173

Open
wants to merge 5 commits into
base: dev
Choose a base branch
from

Conversation

Jaskowicz1
Copy link
Contributor

@Jaskowicz1 Jaskowicz1 commented Jun 18, 2024

This PR raises the minimum gcc/g++ version for Coro from 11 to 13.

This PR also corrects set_emoji (too much text for a @brief, moved most of it to @warning and @note) and set_disabled (previously stated that both true and false would disable a component).

Documentation change checklist

  • My documentation changes follow the docs style guide and any code examples follow the coding style guide.
  • I tested that my change works before raising the PR (via running doxygen, and testing examples).
  • I have not moved any existing pages or changed any existing URLs without strong justification as to why.
  • I have not generated content using AI or a desktop utility such as grammarly.

Copy link

netlify bot commented Jun 18, 2024

Deploy Preview for dpp-dev ready!

Name Link
🔨 Latest commit 15d5993
🔍 Latest deploy log https://app.netlify.com/sites/dpp-dev/deploys/667734280e72b90008e0d24e
😎 Deploy Preview https://deploy-preview-1173--dpp-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added documentation Improvements or additions to documentation code Improvements or additions to code. labels Jun 18, 2024
@braindigitalis
Copy link
Contributor

are you sure 13 is the minimum? ive been using it on v12 in seven spells and beholder just fine, and on my local machine...

@Jaskowicz1
Copy link
Contributor Author

are you sure 13 is the minimum? ive been using it on v12 in seven spells and beholder just fine, and on my local machine...

Not entirely sure to be honest with you. I was under the impression it was gcc13 as minimum.

If you're running coro on 12 then I'll change it to gcc12!

@Mishura4
Copy link
Member

It's for ARM that you need 13

For x86 11 and 12 work but have bugs with lambdas (we already warn about this one in docs)

@Jaskowicz1
Copy link
Contributor Author

For x86 11 and 12 work but have bugs with lambdas (we already warn about this one in docs)

https://discord.com/channels/825407338755653642/825411707521728512/1252545524717064235 https://discord.com/channels/825407338755653642/825411707521728512/1225743126602317834 is it?

Seems like 11 and 12 have issues on these machines (both cases are debian 12 though, so maybe it's a debian thing).

@Mishura4
Copy link
Member

It's for ARM that you need 13

@Jaskowicz1
Copy link
Contributor Author

Jaskowicz1 commented Jun 19, 2024

So, to now update this, it seems it's only gcc12.3 or higher and then a specific version of gcc11 that works.

From talks, it's best to just tell people to use gcc13 or higher. This answers your question about it working on your end @braindigitalis

@Jaskowicz1 Jaskowicz1 requested a review from Mishura4 June 19, 2024 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code Improvements or additions to code. documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants