Skip to content

Conversation

gar1t
Copy link

@gar1t gar1t commented Nov 29, 2018

No description provided.

@craffel
Copy link
Contributor

craffel commented Jan 30, 2019

Thanks for this! It creates a little bit of a semantic clash though - when the checkpoint is latest, it uses results_dir; when it's a path, it assumes a full path. I think it would be fine to make it so when eval_single_checkpoint is a filename, it still uses results_dir to create the full path. WDYT?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants