Skip to content

Conversation

@fra-pa
Copy link
Contributor

@fra-pa fra-pa commented Jun 6, 2021

NPM throws an exception when trying to install dependencies:

git clone https://github.com/bpmn-io/moddle-xml.git
cd moddle-xml
npm install
npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR!
npm ERR! While resolving: [email protected]
npm ERR! Found: [email protected]
npm ERR! node_modules/eslint
npm ERR!   dev eslint@"^7.14.0" from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer eslint@"^2.0.0 || ^3.0.0 || ^4.0.0 || ^5.0.0 || ^6.0.0" from [email protected]
npm ERR! node_modules/eslint-plugin-bpmn-io
npm ERR!   dev eslint-plugin-bpmn-io@"^0.11.0" from the root project
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR!
npm ERR! See //home/frapa//.npm/eresolve-report.txt for a full report.

This happens because eslint is configured to use version ^7.14.0 but version 0.11.0 of eslint-plugin-bpmn-io accepts eslint only up to ^6.0.0.

This PR updates eslint-plugin-bpmn-io to version 0.12.0 which can use eslint up to ^7.0.0 and enables NPM to resolve the dependency.

Bump eslint-plugin-bpmn-io to version 0.12.0 to fix NPM ERESOLVE error.

Version 0.11.0 of lint-plugin-bpmn-io uses eslint versions up to 6.0.0,
but eslint is configured to use 7.14.0. NPM cannot resolve the
dependency and fails to install the modules.

As eslint-plugin-bpmn-io was updated to use eslint up to 7.0.0 with
version 0.12.0 this can be used to fix the issue.
@marstamm
Copy link

marstamm commented Jun 7, 2021

Hi @fra-pa ,

thank you for opening this PR. I could not reproduce the issue with the steps described. What node/npm version are you using?

@fra-pa
Copy link
Contributor Author

fra-pa commented Jun 7, 2021

What node/npm version are you using?

node: 14.16.1
npm: 7.16.0

@marstamm
Copy link

marstamm commented Jun 7, 2021

Thank you for the quick reply! I could recreate the issue when deleting the package-lock first

@marstamm marstamm merged commit 104b846 into bpmn-io:master Jun 7, 2021
@fra-pa
Copy link
Contributor Author

fra-pa commented Jun 7, 2021

Thanks for the quick merge.

deleting the package-lock first

For me also everything worked fine, until I started playing around (in the context of this moddle PR).

@fra-pa fra-pa deleted the fix-dependency-eslint-plugin-bpmn-io branch June 7, 2021 08:51
@nikku
Copy link
Member

nikku commented Jun 9, 2021

For the time being I've reverted the package-lock.json changes (85fcf29). We're still at npm@6 internally and the new lockfile version will blow up things on our end.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants