fix: manage state outside of preact to avoid updates with stale element #122
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Note:
|
barmac
commented
Oct 24, 2025
Comment on lines
-127
to
-143
| useEffect(() => { | ||
| const onRootAdded = (e) => { | ||
| const element = e.element; | ||
|
|
||
| if (isImplicitRoot(element)) { | ||
| return; | ||
| } | ||
|
|
||
| _update(element); | ||
| }; | ||
|
|
||
| eventBus.on('root.added', onRootAdded); | ||
|
|
||
| return () => { | ||
| eventBus.off('root.added', onRootAdded); | ||
| }; | ||
| }, [ selectedElement ]); |
Member
Author
There was a problem hiding this comment.
This logic can be safely removed as we refuse to render implicit root in _render
Contributor
There was a problem hiding this comment.
Yes, it was also removed in bpmn-js-properties-panel.
| eventBus.on('propertiesPanel.providersChanged', () => this._update()); | ||
|
|
||
| // Handle root changes more carefully | ||
| eventBus.on('root.added', (event) => { |
Contributor
There was a problem hiding this comment.
What the hell was the agent doing? 😆
Member
Author
There was a problem hiding this comment.
We had this logic in the component.
This comment was marked as spam.
This comment was marked as spam.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to bpmn-io/bpmn-js-properties-panel#1159
Proposed Changes