Skip to content

feat: complete on blur / focusout #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
nikku wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

feat: complete on blur / focusout #54

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion lib/DirectEditing.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,8 @@ export default function DirectEditing(eventBus, canvas) {
this._textbox = new TextBox({
container: canvas.getContainer(),
keyHandler: bind(this._handleKey, this),
resizeHandler: bind(this._handleResize, this)
resizeHandler: bind(this._handleResize, this),
blurHandler: bind(this._handleBlur, this)
});
}

Expand Down Expand Up @@ -146,6 +147,9 @@ DirectEditing.prototype._handleKey = function(e) {
}
};

DirectEditing.prototype._handleBlur = function(e) {
return this.complete();
};

DirectEditing.prototype._handleResize = function(event) {
this._fire('resize', event);
Expand Down
16 changes: 11 additions & 5 deletions lib/TextBox.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,8 @@ function toArray(nodeList) {
return [].slice.call(nodeList);
}

var noop = function() {};

/**
* Initializes a container for a content editable div.
*
Expand All @@ -44,6 +46,7 @@ function toArray(nodeList) {
* @param {DOMElement} options.container The DOM element to append the contentContainer to
* @param {Function} options.keyHandler Handler for key events
* @param {Function} options.resizeHandler Handler for resize events
* @param {Function} options.blurHandler Handler for blur events
*/
export default function TextBox(options) {
this.container = options.container;
Expand All @@ -56,8 +59,9 @@ export default function TextBox(options) {

this.content = domQuery('[contenteditable]', this.parent);

this.keyHandler = options.keyHandler || function() {};
this.resizeHandler = options.resizeHandler || function() {};
this.keyHandler = options.keyHandler || noop;
this.resizeHandler = options.resizeHandler || noop;
this.blurHandler = options.blurHandler || noop;

this.autoResize = bind(this.autoResize, this);
this.handlePaste = bind(this.handlePaste, this);
Expand All @@ -82,8 +86,6 @@ export default function TextBox(options) {
* @return {DOMElement} The created content DOM element
*/
TextBox.prototype.create = function(bounds, style, value, options) {
var self = this;

var parent = this.parent,
content = this.content,
container = this.container;
Expand Down Expand Up @@ -161,7 +163,7 @@ TextBox.prototype.create = function(bounds, style, value, options) {

domEvent.bind(content, 'keydown', this.keyHandler);
domEvent.bind(content, 'mousedown', stopPropagation);
domEvent.bind(content, 'paste', self.handlePaste);
domEvent.bind(content, 'paste', this.handlePaste);

if (options.autoResize) {
domEvent.bind(content, 'input', this.autoResize);
Expand All @@ -173,6 +175,8 @@ TextBox.prototype.create = function(bounds, style, value, options) {

container.appendChild(parent);

domEvent.bind(parent, 'focusout', this.blurHandler);

// set selection to end of text
this.setSelection(content.lastChild, content.lastChild && content.lastChild.length);

Expand Down Expand Up @@ -421,6 +425,8 @@ TextBox.prototype.destroy = function() {
domRemove(resizeHandle);
}

domEvent.unbind(parent, 'focusout', this.blurHandler);

domRemove(parent);
};

Expand Down