fix: flip default of cancelRemainingInstances #1148
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Buckwich
force-pushed
the
fix-cancelremaintinstances-default
branch
from
499b763 to
e5914ff
Compare
bpmn-io-tasks
bot
added
needs review
philippfromme
force-pushed
the
fix-cancelremaintinstances-default
branch
from
e5914ff to
2660b92
Compare
Change in bpmn-moddle requires latest bpmn-js
philippfromme
approved these changes
Aug 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
bpmn-io/bpmn-moddle#131 changed (ie removed) the
default: trueforcancelRemainingInstances. This change makes the default (isEdited) detection reflect that changeChecklist
To ensure you provided everything we need to look at your PR:
@bpmn-io/srtoolCloses {LINK_TO_ISSUE}orRelated to {LINK_TO_ISSUE}