Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide correlation key on process start events #31

Merged
merged 5 commits into from
Nov 24, 2023
Merged

Conversation

marstamm
Copy link
Collaborator

@marstamm marstamm commented Nov 23, 2023

Closes #19

@marstamm marstamm requested a review from a team November 23, 2023 09:59
@marstamm marstamm self-assigned this Nov 23, 2023
@marstamm marstamm requested review from philippfromme and barmac and removed request for a team November 23, 2023 10:00
@bpmn-io-tasks bpmn-io-tasks bot added the needs review Review pending label Nov 23, 2023
return !isActive;
}

return isActive ? isConditionMet(element, properties, relatedCondition) : !isConditionMet(element, properties, relatedCondition);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is basically:

Suggested change
return isActive ? isConditionMet(element, properties, relatedCondition) : !isConditionMet(element, properties, relatedCondition);
return isActive === isConditionMet(element, properties, relatedCondition);

Copy link
Member

@barmac barmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Let's merge this.

@fake-join fake-join bot merged commit 8ccc64e into main Nov 24, 2023
5 checks passed
@fake-join fake-join bot deleted the filter-correlation-key branch November 24, 2023 14:50
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Nov 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Connectors element templates: conditional field rendering based on placement
2 participants