Skip to content

Commit

Permalink
prep build 11/22
Browse files Browse the repository at this point in the history
  • Loading branch information
bph committed Nov 22, 2024
2 parents 81fe522 + 81d2ee8 commit a866fa1
Show file tree
Hide file tree
Showing 11 changed files with 53 additions and 21 deletions.
6 changes: 4 additions & 2 deletions .github/workflows/gradle-wrapper-validation.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,9 @@ jobs:
name: 'Validation'
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
- name: Checkout repository
uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
with:
show-progress: ${{ runner.debug == '1' && 'true' || 'false' }}
- uses: gradle/wrapper-validation-action@v3
- name: Validate checksums
uses: gradle/actions/wrapper-validation@cc4fc85e6b35bafd578d5ffbc76a5518407e1af0 # v4.2.1
11 changes: 6 additions & 5 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@
"eslint-import-resolver-node": "0.3.4",
"eslint-plugin-eslint-comments": "3.1.2",
"eslint-plugin-import": "2.25.2",
"eslint-plugin-jest": "27.2.3",
"eslint-plugin-jest": "27.4.3",
"eslint-plugin-jest-dom": "5.0.2",
"eslint-plugin-prettier": "5.0.0",
"eslint-plugin-react-compiler": "19.0.0-beta-0dec889-20241115",
Expand Down
24 changes: 23 additions & 1 deletion packages/block-library/src/details/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
* WordPress dependencies
*/
import { details as icon } from '@wordpress/icons';
import { __ } from '@wordpress/i18n';
import { __, sprintf } from '@wordpress/i18n';

/**
* Internal dependencies
Expand Down Expand Up @@ -34,6 +34,28 @@ export const settings = {
},
],
},
__experimentalLabel( attributes, { context } ) {
const { summary } = attributes;

const customName = attributes?.metadata?.name;
const hasSummary = summary?.trim().length > 0;

// In the list view, use the block's summary as the label.
// If the summary is empty, fall back to the default label.
if ( context === 'list-view' && ( customName || hasSummary ) ) {
return customName || summary;
}

if ( context === 'accessibility' ) {
return ! hasSummary
? __( 'Details. Empty.' )
: sprintf(
/* translators: accessibility text; summary title. */
__( 'Details. %s' ),
summary
);
}
},
save,
edit,
transforms,
Expand Down
2 changes: 1 addition & 1 deletion packages/block-library/src/navigation/style.scss
Original file line number Diff line number Diff line change
Expand Up @@ -510,7 +510,7 @@ button.wp-block-navigation-item__content {
padding-top: clamp(1rem, var(--wp--style--root--padding-top), 20rem);
padding-right: clamp(1rem, var(--wp--style--root--padding-right), 20rem);
padding-bottom: clamp(1rem, var(--wp--style--root--padding-bottom), 20rem);
padding-left: clamp(1rem, var(--wp--style--root--padding-left), 20em);
padding-left: clamp(1rem, var(--wp--style--root--padding-left), 20rem);

// Allow modal to scroll.
overflow: auto;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,15 +18,13 @@ export default function EnhancedPaginationControl( {
const fullPageClientSideNavigation =
window.__experimentalFullPageClientSideNavigation;

let help = __( 'Browsing between pages requires a full page reload.' );
let help = __(
'Reload the full page—instead of just the posts list—when visitors navigate between pages.'
);
if ( fullPageClientSideNavigation ) {
help = __(
'Experimental full-page client-side navigation setting enabled.'
);
} else if ( enhancedPagination ) {
help = __(
'Reload the full page—instead of just the posts list—when visitors navigate between pages.'
);
} else if ( hasUnsupportedBlocks ) {
help = __(
'Enhancement disabled because there are non-compatible blocks inside the Query block.'
Expand Down
2 changes: 2 additions & 0 deletions packages/block-library/src/social-link/editor.scss
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,8 @@
font-size: inherit;
color: currentColor;
height: auto;
font-weight: inherit;
font-family: inherit;

// This rule ensures social link buttons display correctly in template parts.
opacity: 1;
Expand Down
1 change: 1 addition & 0 deletions packages/components/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@

- `SlotFill`: fix dependencies of `Fill` registration effects ([#67071](https://github.com/WordPress/gutenberg/pull/67071)).
- `SlotFill`: rewrite the `Slot` component from class component to functional ([#67153](https://github.com/WordPress/gutenberg/pull/67153)).
- `Menu.ItemHelpText`: Fix text wrapping to prevent unintended word breaks ([#67011](https://github.com/WordPress/gutenberg/pull/67011)).

## 28.12.0 (2024-11-16)

Expand Down
2 changes: 1 addition & 1 deletion packages/components/src/menu/styles.ts
Original file line number Diff line number Diff line change
Expand Up @@ -380,7 +380,7 @@ export const MenuItemHelpText = styled( Truncate )`
font-size: ${ font( 'helpText.fontSize' ) };
line-height: 16px;
color: ${ LIGHTER_TEXT_COLOR };
word-break: break-all;
overflow-wrap: anywhere;
[data-active-item]:not( [data-focus-visible] )
*:not( ${ MenuPopoverInnerWrapper } )
Expand Down
Original file line number Diff line number Diff line change
@@ -1,10 +1,13 @@
/**
* WordPress dependencies
*/
import {
privateApis as blockEditorPrivateApis,
store as blockEditorStore,
} from '@wordpress/block-editor';
import { Card, CardBody } from '@wordpress/components';
import { useSelect, useDispatch } from '@wordpress/data';
import { __ } from '@wordpress/i18n';
import { privateApis as blockEditorPrivateApis } from '@wordpress/block-editor';
import { useDispatch } from '@wordpress/data';
import { store as editorStore } from '@wordpress/editor';
import { useEffect } from '@wordpress/element';

Expand All @@ -19,10 +22,13 @@ const { useZoomOut } = unlock( blockEditorPrivateApis );

function ScreenStyleVariations() {
// Style Variations should only be previewed in with
// - a "zoomed out" editor
// - a "zoomed out" editor (but not when in preview mode)
// - "Desktop" device preview
const isPreviewMode = useSelect( ( select ) => {
return select( blockEditorStore ).getSettings().isPreviewMode;
}, [] );
const { setDeviceType } = useDispatch( editorStore );
useZoomOut();
useZoomOut( ! isPreviewMode );
useEffect( () => {
setDeviceType( 'desktop' );
}, [ setDeviceType ] );
Expand Down
2 changes: 1 addition & 1 deletion packages/eslint-plugin/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@
"cosmiconfig": "^7.0.0",
"eslint-config-prettier": "^8.3.0",
"eslint-plugin-import": "^2.25.2",
"eslint-plugin-jest": "^27.2.3",
"eslint-plugin-jest": "^27.4.3",
"eslint-plugin-jsdoc": "^46.4.6",
"eslint-plugin-jsx-a11y": "^6.5.1",
"eslint-plugin-playwright": "^0.15.3",
Expand Down

0 comments on commit a866fa1

Please sign in to comment.