Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docs): document specifics of "ballooning device" in the vm.memory block #1550

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

bpg
Copy link
Owner

@bpg bpg commented Sep 24, 2024

Contributor's Note

  • I have added / updated documentation in /docs for any user-facing features or additions.
  • I have added / updated acceptance tests in /fwprovider/tests for any new or updated resources / data sources.
  • I have ran make example to verify that the change works as expected.

Proof of Work

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #634

@bpg
Copy link
Owner Author

bpg commented Sep 24, 2024

Note: we should changed the default behaviour (i.e. enable ballooning by default) in v1.x:

@bpg bpg enabled auto-merge (squash) September 24, 2024 00:12
@bpg bpg merged commit 0b29ae2 into main Sep 24, 2024
8 checks passed
Copy link

@mergify mergify bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 LGTM! beep boop

@bpg bpg deleted the pb-memory-baloon branch September 24, 2024 00:12
@bpg bpg changed the title fix(docs): document specifics of "ballooning device" in the `vm.memor… fix(docs): document specifics of "ballooning device" in the vm.memory block Sep 24, 2024
@bpg bpg changed the title fix(docs): document specifics of "ballooning device" in the vm.memory block chore(docs): document specifics of "ballooning device" in the vm.memory block Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add possibility to control Ballooning Device
1 participant