Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(vm2): add initial support for cdrom #1370

Merged
merged 1 commit into from
Jun 10, 2024
Merged

chore(vm2): add initial support for cdrom #1370

merged 1 commit into from
Jun 10, 2024

Conversation

bpg
Copy link
Owner

@bpg bpg commented Jun 9, 2024

This is a breaking change comparing to v1 - switching the cdrom schema from a nested block to a nested attribute map.

Improvements comparing to v1:

  • support for ide, sata, scsi interfaces
  • support for multiple cdroms

Contributor's Note

  • I have added / updated documentation in /docs for any user-facing features or additions.
  • I have added / updated acceptance tests in /fwprovider/tests for any new or updated resources / data sources.
  • I have ran make example to verify that the change works as expected.

Proof of Work

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #1231
Relates #718

@bpg bpg marked this pull request as draft June 9, 2024 15:11
@bpg bpg force-pushed the vm2-cdrom branch 3 times, most recently from b720f51 to 9cf5708 Compare June 9, 2024 22:02
@bpg bpg marked this pull request as ready for review June 9, 2024 22:09
This is a breaking change comparing to v1 - switching the cdrom schema from a nested block to a nested attribute map.

Improvements comparing to v1:
- support for `ide`, `sata`, `scsi` interfaces
- support for multiple cdroms

Signed-off-by: Pavel Boldyrev <[email protected]>
@bpg bpg enabled auto-merge (squash) June 10, 2024 01:28
Copy link

@mergify mergify bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 LGTM! beep boop

@bpg bpg merged commit 80cafa6 into main Jun 10, 2024
7 checks passed
@bpg bpg deleted the vm2-cdrom branch June 10, 2024 01:28
@bpg bpg changed the title feat(vm2): add initial support for cdrom chore(vm2): add initial support for cdrom Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant