Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(vm2): experiment with sets, add tags support #1232

Merged
merged 2 commits into from
Apr 21, 2024
Merged

Conversation

bpg
Copy link
Owner

@bpg bpg commented Apr 21, 2024

Contributor's Note

  • I have added / updated documentation in /docs for any user-facing features or additions.
  • I have added / updated acceptance tests in /fwprovider/tests for any new or updated resources / data sources.
  • I have ran make example to verify that the change works as expected.

Proof of Work

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #1231

@bpg bpg force-pushed the vm2-experiment-with-sets branch from 44f2c76 to f57d07b Compare April 21, 2024 00:12
@bpg bpg marked this pull request as ready for review April 21, 2024 00:15
@bpg bpg enabled auto-merge (squash) April 21, 2024 00:15
Copy link

@mergify mergify bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 LGTM! beep boop

@bpg bpg merged commit 961404d into main Apr 21, 2024
7 checks passed
@bpg bpg deleted the vm2-experiment-with-sets branch April 21, 2024 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant