WIP: Branch for testing API review #480
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implements status conditions and component status tracking for the Config custom resource to provide visibility into the reconciliation state of managed components (ConfigMap, DaemonSets, CSIDriver, SCC). - Add ConfigComponentStatuses type with status for each component - Implement Progressing and Available conditions following Kubernetes conventions - Add event recording for status changes - Update controller with status subresource RBAC permissions - Add test coverage for all status states - Integrate status checks into lifecycle tests The status system tracks individual component readiness and sets overall conditions to indicate when the Config is progressing or fully available. Signed-off-by: Andreas Karis <[email protected]>
Signed-off-by: Andreas Karis <[email protected]>
Update ConfigSpec and AgentSpec field documentation to follow OpenShift API conventions (lowercase first letter). Remove redundant kubebuilder validation tags and make HealthProbePort optional with a default value of 8175 applied via the controller instead of via the API. Signed-off-by: Andreas Karis <[email protected]>
Signed-off-by: Andreas Karis <[email protected]>
Add checkResourcesInDesiredState function to verify that the default health probe port (8175) is correctly applied to bpfman and metrics proxy DaemonSets when not explicitly set in the Config spec. This test ensures the default value handling introduced in the API standards compliance changes works correctly at runtime. Signed-off-by: Andreas Karis <[email protected]>
Signed-off-by: Andreas Karis <[email protected]>
Signed-off-by: Andreas Karis <[email protected]>
Method GetClientObject is not used and removing it removes the dependency on sigs.k8s.io/controller-runtime/pkg/client Signed-off-by: Andreas Karis <[email protected]>
andreaskaris
changed the title
Signed-off-by: Andreas Karis <[email protected]>
andreaskaris
force-pushed
the
conditions-api-changes
branch
4 times, most recently
from
fe835c1 to
d791fa3
Compare
Signed-off-by: Andreas Karis <[email protected]>
andreaskaris
force-pushed
the
conditions-api-changes
branch
from
d791fa3 to
99eab34
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is just to run CI and to keep API review changes and actual code in sync
API review is here: openshift/api#2521
Conventions: https://github.com/openshift/enhancements/blob/master/dev-guide/api-conventions.md