Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for acroforms #2373

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add support for acroforms #2373

wants to merge 1 commit into from

Conversation

Heston1
Copy link

@Heston1 Heston1 commented Dec 21, 2021

A feature implementing AcroForms since its supported in the underlying library PDFKit although there is no direct support for checkboxes and radio buttons because it was removed in PDFKit but I've decided to implement it here.
download.pdf

@liborm85
Copy link
Collaborator

Files src/pdf-kit-extensions/PDFEmbeddedFont.js and src/pdf-kit-extensions/StandardFonts.js in pdfmake are they needed for what?

Checkboxes and radios support in src/pdf-kit-extensions/ExtendedAcroFormMixin.js will be better first implemented in pdfkit.

@Heston1
Copy link
Author

Heston1 commented Dec 27, 2021

PDFEmbeddedFont.js is a workaround to embed the entire font, pdfkit doesn't have an option to do this that's why there is this issue foliojs/pdfkit#1096, in adobe acrobat it defaults to another OpenType font if the glyph is not included I think to something like myriadpro, whereas with chrome you only see the glyphs included in that subset font only, atm im using this for something but I will try to get checkboxes and radio forms, and this issue in pdfkit and get back to this when its in.

@liborm85
Copy link
Collaborator

foliojs/pdfkit#1096 require fix in pdfkit (not in pdfmake).

@reinerBa
Copy link

reinerBa commented Feb 9, 2022

@Heston1 Great work, a layout for forms is exactly what need ❤. I will try to use it as fast as possible.
Maybe you should also include your features in the features list in the readme.md?

@PandaaAgency
Copy link

hi, any news on this pr ?

@reinerBa
Copy link

reinerBa commented May 6, 2022

Please merge the PR, i'm using it with success.

@techquestions
Copy link

@reinerBa can you please resolve conflicts?

@liborm85 @bpampuch do you approve this feature to be added to PDFMake?

@reinerBa
Copy link

@techquestions Sorry but i haven't written any Code in here and i see no conflicts. I did just build the fork of Heston1 for my purpose.

@kylecordes
Copy link

kylecordes commented Jun 1, 2022

Utter heros in here.

I'm seriously considering using an unmerged PR... based on an alpha not-for-production version... of a lightly-maintained project... in production.

@majid701
Copy link

Is there any progress on this? Will this be merged at some point or not at all?

@Padi2312
Copy link

Is there any progress now ?
Still waiting for this feature - does it ever get merged ?

@Torres1080
Copy link

Any update on this?

@becca-frick
Copy link

Has there been any progress on this lately?

@shami-bhumio
Copy link

Any updates on this?

@WKampel
Copy link

WKampel commented Dec 5, 2024

This would be great

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.