Cisdev moodle simple certificate #281
Conversation
|
Hi @sudhakar-cisinlabs ... Please explain this feature. Also, please send me the steps to test the functionality. Gracias Saludos |
There was a problem hiding this comment.
@sudhakar-cisinlabs Please fix that variable naming, besides of that the PR looks good for me. Will merge when done.
classes/observer.php
Outdated
|
|
||
|
|
||
| $authogeneratecertificate = $DB->get_record('simplecertificate', ['course' => $courseid], 'autogeneratecertificate'); | ||
| if(!$authogeneratecertificate || $authogeneratecertificate->autogeneratecertificate === 0) |
There was a problem hiding this comment.
@sudhakar-cisinlabs Typo in naming: Please use $autoGenerateCertificate for the name of the variable. Thanks
There was a problem hiding this comment.
I have made the changes as per your request.
There was a problem hiding this comment.
@sudhakar-cisinlabs You are in the wrong repo though. This was intended for the fork: https://github.com/vmk-dev/moodle-mod_simplecertificate
@davidherney That was actually a special task, not intended for your main repo. All open source though, so if you like any functionality be free to pick or merge.
Added the code for generating the simple certificate, Please check and let me know.