Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manage Products Feature #1943

Draft
wants to merge 14 commits into
base: master
Choose a base branch
from
Draft

Manage Products Feature #1943

wants to merge 14 commits into from

Conversation

fhenrich33
Copy link
Contributor

@fhenrich33 fhenrich33 commented Jan 31, 2025

image

Screen Shot 2025-02-06 at 09 02 07

@fhenrich33
Copy link
Contributor Author

@fhenrich33
Copy link
Contributor Author

@fhenrich33
Copy link
Contributor Author

Copy link
Member

@HaGuesto HaGuesto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fhenrich33 feels like there is still lots of left over code from copy/pasting the table from Manage Boxes.

front/src/App.tsx Outdated Show resolved Hide resolved
front/src/views/Products/ProductsView.tsx Show resolved Hide resolved
front/src/views/Products/ProductsView.tsx Outdated Show resolved Hide resolved
front/src/views/Products/ProductsView.tsx Outdated Show resolved Hide resolved
front/src/views/Products/components/Checkbox.tsx Outdated Show resolved Hide resolved
front/src/views/Products/components/ColumnSelector.tsx Outdated Show resolved Hide resolved
front/src/views/Products/components/ColumnSelector.tsx Outdated Show resolved Hide resolved
front/src/views/Products/components/Filter.tsx Outdated Show resolved Hide resolved
front/src/views/Products/components/GlobalFilter.tsx Outdated Show resolved Hide resolved
@aerinsol
Copy link
Member

aerinsol commented Feb 6, 2025

Not yet complete:

  • Enable/disable ASSORT products
  • redirect from Dropapp

My proposal: enable this for beta users who are transitioning into ASSORT, hide for everyone else. We can get some immediate feedback this way. We can follow up with the incomplete items in a later wide release.

@fhenrich33
Copy link
Contributor Author

@fhenrich33 feels like there is still lots of left over code from copy/pasting the table from Manage Boxes.

@HaGuesto Indeed, it was a crude WIP. Most if not all points were addressed.

@fhenrich33
Copy link
Contributor Author

@aerinsol WDYT of the current interaction design wise?

@aerinsol
Copy link
Member

aerinsol commented Feb 6, 2025

I think it looks fine @fhenrich33 . I would like there to be a default sort first by enabled/disabled items, then alphabetically by product name

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants