-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update FE docs and add gql.tada ADR #1880
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FE Readme changes approved 😅 the ADR sounds good too
@aerinsol @HaGuesto @jlin95 @vahidbazzaz Thoughts? Also there's another FE README update in the Playwright PR. |
Signed-off-by: Felipe Henrich <[email protected]>
Signed-off-by: Felipe Henrich <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1880 +/- ##
=======================================
Coverage 84.42% 84.42%
=======================================
Files 244 244
Lines 15334 15334
Branches 2219 2219
=======================================
Hits 12946 12946
Misses 2348 2348
Partials 40 40
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Rendered gql.tada ADR: https://github.com/boxwise/boxtribute/blob/d13d1c350e6289e7164f6d54e5f67d24ede1b3d0/docs/adr/adr-typing-graphql.md
Updated FE README: https://github.com/boxwise/boxtribute/blob/de20ee98f57c470f64b5f82549dc3f17650e541b/front/README.md