Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update FE docs and add gql.tada ADR #1880

Merged
merged 7 commits into from
Jan 14, 2025

Conversation

Copy link
Contributor

@pylipp pylipp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FE Readme changes approved 😅 the ADR sounds good too

@fhenrich33
Copy link
Contributor Author

@aerinsol @HaGuesto @jlin95 @vahidbazzaz Thoughts?

Also there's another FE README update in the Playwright PR.

Signed-off-by: Felipe Henrich <[email protected]>
Copy link

codecov bot commented Jan 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.42%. Comparing base (a35d527) to head (d579f95).
Report is 8 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1880   +/-   ##
=======================================
  Coverage   84.42%   84.42%           
=======================================
  Files         244      244           
  Lines       15334    15334           
  Branches     2219     2219           
=======================================
  Hits        12946    12946           
  Misses       2348     2348           
  Partials       40       40           
Flag Coverage Δ
backend 99.12% <ø> (ø)
frontend 78.18% <ø> (ø)
sharedComponents 78.38% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fhenrich33 fhenrich33 merged commit 9f0b882 into master Jan 14, 2025
11 checks passed
@fhenrich33 fhenrich33 deleted the update-fe-docs-plus-gql.tada-adr branch January 14, 2025 22:39
@fhenrich33
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants