Use peewee iterator in loaders #1495
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pylipp
force-pushed
the
use-peewee-iterator-in-loaders
branch
from
48300fd to
2861565
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1495 +/- ##
=======================================
Coverage 84.47% 84.48%
=======================================
Files 246 246
Lines 15462 15464 +2
Branches 2248 2248
=======================================
+ Hits 13062 13064 +2
Misses 2359 2359
Partials 41 41
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
cf. http://docs.peewee-orm.com/en/latest/peewee/querying.html#iterating-over-large-result-sets > To reduce the amount of memory used by peewee when iterating over a > query, use the iterator() method. This method allows you to iterate > without caching each model returned, using much less memory when > iterating over large result sets.
[skip ci]
pylipp
force-pushed
the
use-peewee-iterator-in-loaders
branch
from
2861565 to
f92f3cb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cf. http://docs.peewee-orm.com/en/latest/peewee/querying.html#iterating-over-large-result-sets