This repository has been archived by the owner on May 26, 2022. It is now read-only.
Update GlobalFunctionsHelper.php #859
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
adrilo
reviewed
Jan 28, 2022
| @@ -248,7 +248,7 @@ public function is_readable($fileName) | |||
| */ | |||
| public function basename($path, $suffix = null) | |||
There was a problem hiding this comment.
looking at the method signature (https://www.php.net/manual/en/function.basename), it should be:
public function basename($path, $suffix = '')
Changing the signature (and associated PHPDoc) would be a better fix I believe.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHP 8.1 issue. $suffix may not be null when using PHP's basename function. Default value is an empty string. Belongs to issue #844