ThirdPartySyncCommand - Adding new parameters #613
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tions implementation
aurambaj
reviewed
Jul 25, 2020
| @@ -217,7 +218,6 @@ | |||
| <groupId>com.box.l10n.mojito</groupId> | |||
| <artifactId>mojito-restclient</artifactId> | |||
| <version>0.111-SNAPSHOT</version> | |||
| <scope>test</scope> | |||
There was a problem hiding this comment.
why removing the test scope here?
| @@ -205,6 +205,7 @@ | |||
| <dependency> | |||
| <groupId>junit</groupId> | |||
| <artifactId>junit</artifactId> | |||
| <scope>test</scope> | |||
| @@ -54,8 +54,7 @@ | |||
| @Parameter(names = {Param.TARGET_DIRECTORY_LONG, Param.TARGET_DIRECTORY_SHORT}, arity = 1, required = false, description = Param.TARGET_DIRECTORY_DESCRIPTION) | |||
| String targetDirectoryParam; | |||
|
|
|||
| @Parameter(names = {Param.REPOSITORY_LOCALES_MAPPING_LONG, Param.REPOSITORY_LOCALES_MAPPING_SHORT}, arity = 1, required = false, description = "Locale mapping, format: \"fr:fr-FR,ja:ja-JP\". " | |||
| + "The keys contain BCP47 tags of the generated files and the values indicate which repository locales are used to fetch the translations.") | |||
| @Parameter(names = {Param.REPOSITORY_LOCALES_MAPPING_LONG, Param.REPOSITORY_LOCALES_MAPPING_SHORT}, arity = 1, required = false, description = Param.REPOSITORY_LOCALES_MAPPING_DESCRIPTION) | |||
| getL10nJCommander().run("thirdparty-sync", "-r", repository.getName(), "-p", "does-not-matter-yet", "-ps", " _"); | ||
| String projectId = testIdWatcher.getEntityName("projectId"); | ||
|
|
||
| // TODO: For a plural separator like " _" this test will fail. The current version we have for |
There was a problem hiding this comment.
I see now why you created the issue
| public void setUp() throws Exception { | ||
| testingJobListener = new TestingJobListener(objectMapper); | ||
| jobMatcher = new PollableTaskJobMatcher<>(ThirdPartySyncJob.class); | ||
| scheduler.getListenerManager().addJobListener(testingJobListener, jobMatcher); |
There was a problem hiding this comment.
this will also impact other test, i'm always reticent with changing the application context. Can we validate in some other ways?
|
Closed in favor of #614 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To implement the
PULL,PUSHandPUSH_TRANSLATIONScommands inThirdPartyService, we need to updateThirdPartySyncCommandand several dependencies to utilize these new parameters:--skip-text-units-with-patternand--skip-assets-path-pattern.Please note the TODO added to
ThirdPartySyncCommandTestand documented in #612