Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

add all assistant data from cmpe.boun.edu.tr #15

Merged
merged 7 commits into from
Jul 24, 2023

Conversation

furkanakkurt1335
Copy link
Contributor

as per issue #11

Copy link
Member

@doganulus doganulus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Data and assets must be separated into two branches & PRs. We must be careful when pushing binary blobs. Let's delay merging images for some time.
  2. Data field for interests must use predefined short strings for i18n.
  3. Not sure about the lab field. This doesn't have to be a one-to-one relationship. I tend to leave it under a more general tags field. In both cases, lab info must be denoted as a short string like colors, soslab, etc.

@doganulus doganulus self-requested a review July 14, 2023 11:55
@furkanakkurt1335
Copy link
Contributor Author

furkanakkurt1335 commented Jul 20, 2023

  • Interests should be changed to the new arXiv tags defined in i18n files in the theme.
  • Removed the images from the PR.
  • Change the lab field to tags.

@furkanakkurt1335
Copy link
Contributor Author

This should be complete.

@doganulus
Copy link
Member

Two things:

  • Do not include photos in this PR. We will delay adding photos.
  • The field 'tags' must be an array of strings. Don't use the 'affiliation' key.

@furkanakkurt1335
Copy link
Contributor Author

Sorry, I had removed the images but they came back with another "add". Now, it should be OK.

@doganulus doganulus merged commit aeff991 into bouncmpe:main Jul 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants