fix(skills): green the skill-flow gate — allowlist renamed reverse-engineer#852
Merged
Conversation
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_942bff22-3a15-4e0f-b09b-c321ac2aae15) |
…gineer main renamed skills/reverse-engineer-rpi -> skills/reverse-engineer but left the old name in scripts/skill-flow-standalone.txt, so the renamed skill is an un-allowlisted orphan and validate-skill-flow fails on main (1 finding). Rename the allowlist entry to match. Gate now passes: 75 skills, 122 edges, 9 orphans (all allowlisted), zero hard findings. (The dangling pruned-skill references this branch originally fixed were independently fix-forwarded on main in the interim, so this branch is reset to just the one remaining fix.)
boshu2
force-pushed
the
fix/skill-flow-prune-danglers
branch
from
d986378 to
85ca667
Compare
boshu2
changed the title
… add new skill features skill-gates (check-scenario-test-linkage) was red on main: the beads skill was deleted (stale allowlist entry) and four new skills' .feature files (behavior-first-planning, dual-pane-atm, orchestrate, reverse-engineer) were never allowlisted. Reconcile the allowlist. Gate now PASSES (203 scenarios, 45 doc-only files).
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_2a813c76-562b-4ed8-8426-705634aa94a9) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
validate-skill-flowis red onmainwith one finding:reverse-engineeris an un-allowlisted orphan.mainrenamedskills/reverse-engineer-rpi→skills/reverse-engineerbut left the old name inscripts/skill-flow-standalone.txt, so the renamed skill has no allowlist entry and the gate fails (contracts-syncjob).What
One line: rename the allowlist entry
reverse-engineer-rpi→reverse-engineerto match the skill rename. This simultaneously drops the now-stale dead ref and allowlists the actual orphan.History note
This branch originally removed dangling references to six pruned skills (
operating-loop-skill,brainstorm,design,ratchet,complexity,cass-memory). In the interim (~478 commits),mainindependently fix-forwarded all of those, so the branch has been reset tomain+ this single remaining fix — the only thing still keeping the gate red.Bounded-context: BC1-Corpus
Evidence: OK: skill flow is connected and the consumes vocabulary is closed.