Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added SparklinesInteractiveLayer #119

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

vegetableman
Copy link

Made it a little interactive

interactive

@arslanhashmi
Copy link

arslanhashmi commented Jul 11, 2020

@borisyankov are we going to have this similar interactive layer at some point?

@qcho
Copy link

qcho commented Sep 3, 2021

Great PR! Just what I was looking for.

Question. Did you need an updated version of react and react-dom for this?

If not, it's probably making the scope for this PR bigger than it should

@vegetableman
Copy link
Author

vegetableman commented Sep 5, 2021

It's been 3 years... time sure passes.

Anyways, @qcho had to check my code again. On the issue, I updated react because I was using React.Fragment which is not supported in react 15.

Have updated the PR now and I have removed fragment, reverted the versions back to old one and now am using the svg g tag which works equally well.

Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants