Remove special handling for Vector and Matrix #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm merging this because there is no API breakage and there are obvious benefits. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the various checks in
type.pyfor special handling ofgtsam::Vectorandgtsam::Matrix.As detailed in #164 this helps alleviate issues when it comes to wrapping Eigen types in template definitions (e.g.
std::vector<Matrix>), but puts the onus on the developer to add the appropriate namespaces.I personally believe having the developer specify the namespace and whether it is a reference type helps with clarity and makes debugging easier.
The changes here have been tested out on GTSAM and they work without any issues.