Parse dunder methods in interface file #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gchenfc
requested changes
Jan 15, 2024
gchenfc
approved these changes
Jan 15, 2024
| elif method.name == 'contains': | ||
| function_call = f"return self->find({method.args.args_list[0].name}) != self->end();" | ||
| function_call = f"return std::find(self->begin(), self->end(), {method.args.args_list[0].name}) != self->end();" |
There was a problem hiding this comment.
Sorry for the back-and-forth, but realizing that std::find(..) is always O(n) whereas for many data structures (e.g. std::set) self->find(obj) should be O(1), so probably using the ->find() version would be better in this case? Overkill approach I guess would be SFINAE, but that seems excessive in this case.
There was a problem hiding this comment.
Make up your mind, my guy 😂
I figured the find method would be faster but whoever designed the STL didn't think to make find a method for vectors and lists.
Also, this feature is not crucial. If people want efficiency, then cast to a Python set object (which is easily doable now since we support iteration).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for specifying particular double-underscore aka
dundermethods. This allows giving support for those methods particularly for classes that should behave like python containers e.g.gtsam::KeySet.This will be used to fix borglab/gtsam#1606