Skip to content

testsuite: corrupt archive metadata mid-object to fix flaky windows check test #9796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ThomasWaldmann merged 1 commit into from
Jun 20, 2026
Merged

testsuite: corrupt archive metadata mid-object to fix flaky windows check test #9796

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/borg/testsuite/archiver/check_cmd_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -304,7 +304,9 @@ def test_manifest_rebuild_corrupted_chunk(archivers, request):
corrupted_manifest = corrupt(manifest, 250)
repository.put_manifest(corrupted_manifest)
chunk = repository.get(archive.id)
corrupted_chunk = corrupt(chunk, -1)
# corrupt a byte in the middle of the object: the last byte can land on store-level
# framing rather than the authenticated payload, which made the repair flaky on Windows.
corrupted_chunk = corrupt(chunk, len(chunk) // 2)
repository.put(archive.id, corrupted_chunk)
cmd(archiver, "check", exit_code=1)
output = cmd(archiver, "check", "-v", "--repair", exit_code=0)
Expand Down
Loading