Skip to content

Exclude based on xattrs or NODUMP flag #8895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

ThomasWaldmann
Copy link
Member

No description provided.

Copy link

codecov bot commented Jun 1, 2025

Codecov Report

Attention: Patch coverage is 84.21053% with 3 lines in your changes missing coverage. Please review.

Project coverage is 82.00%. Comparing base (3b94130) to head (2129d81).
Report is 20 commits behind head on master.

Files with missing lines Patch % Lines
src/borg/archive.py 76.92% 1 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8895      +/-   ##
==========================================
- Coverage   82.10%   82.00%   -0.10%     
==========================================
  Files          74       74              
  Lines       13368    13374       +6     
  Branches     1977     1979       +2     
==========================================
- Hits        10976    10968       -8     
- Misses       1739     1746       +7     
- Partials      653      660       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ThomasWaldmann ThomasWaldmann force-pushed the exclude-based-on-xattrs branch from 77c91eb to d748fc9 Compare June 1, 2025 19:37
@ThomasWaldmann ThomasWaldmann changed the title Exclude based on xattrs Exclude based on xattrs or NODUMP flag Jun 2, 2025
…4972

no options yet, just hardcoded macOS and Linux xattrs.
removed the --exclude-nodump option, it is also done automagically now.

also: create: call stat_ext_attrs early

this reads bsdflags, xattrs and ACLs from the
filesystem, except if the user chose to disable that.

notable:
- borg always reads these, even for unchanged files
- if we read them early, borg can now behave differently
  based e.g. on a xattr value (and e.g. exclude the file)
@ThomasWaldmann ThomasWaldmann force-pushed the exclude-based-on-xattrs branch from d748fc9 to 2129d81 Compare June 3, 2025 10:58
@ThomasWaldmann ThomasWaldmann merged commit 7ec02dc into borgbackup:master Jun 3, 2025
15 of 16 checks passed
@ThomasWaldmann ThomasWaldmann deleted the exclude-based-on-xattrs branch June 3, 2025 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant