Remove Gemfile from demo/ #774
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the
demo/Gemfileanddemo/Gemfile.lock. This follows what you get when you generate a plugin or engine withrails plugin new. The Rails files, particularlyconfig/boot.rbfor the "dummy" app generated byrails plugin newrefer to theGemfilein the root directory of the gem.We have our own test app in
demo(for historical reasons). For most purposes, you can work in the demo directory as if it were a regular Rails application. But you must not put aGemfilethere, because it won't get used and you'll only confuse yourself.This also means that prefixing
bundle execin thedemodirectoy won't work, becausebundlewon't find aGemfile. (Unless you also prefix the command withBUNDLE_GEMFILE=<path to gemfile>.)Note, however, that in the CI file
.github/workflows/ruby.yml, we do usebundle exec. This is because all our gemfiles seem to want a different version of Rake than the one standard in the Ubuntu version. If we dodn't dobundle exec, we get theYou have alread activated rake version ..., but your gemfile specifies rake version ...message.