Still trying to handle rich_textarea #768
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lcreid
force-pushed
the
another-dont-define-rich-textarea
branch
from
767a7c0 to
9d23632
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All other attempts seemed to be too clever. I could get tests to pass in this repo, but then
bootstrap_formwouldn't work in a Rails app without ActionText. Or vice versa.Finally, this PR does the obvious: Check if the class responds to
rich_text_area. FIngers crossed.Also, I didn't investigate when I broke the support for an app not to include Trix. This is going to be a weakness going forward, compounded by the fact that Rails is going to drop Trix for Lexxy.