Update eslint-plugin-node to the latest version 🚀 #9
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version 5.0.0 of eslint-plugin-node just got published.
The version 5.0.0 is not covered by your current version range.
Without accepting this pull request your project will work just like it did before. There might be a bunch of new features, fixes and perf improvements that the maintainers worked on for you though.
I recommend you look into these changes and try to get onto the latest version of eslint-plugin-node.
Given that you have a decent test suite, a passing build is a strong indicator that you can take advantage of these changes by merging the proposed change into your project. Otherwise this branch is a great starting point for you to work on the update.
Release Notes
v5.0.0Notable changes are 2:
no-unpublish-import
rule andno-unpublish-require
rule.Breaking changes
no-unsupported-features
rule for Node.js 8.4.0.0
if you don't specify the node version. It has been0.10.0
before.SharedArrayBuffer
andAtomics
. Currently any versions of Node.js don't support those variables.no-deprecated-api
rule for Node.js 8.vm.runInDebugContext()
.no-unpublish-import
rule andno-unpublish-require
rule.New rules
require()
expressions orimport
declarations if those import extraneous packages.no-unpublished-require
andno-unpublished-import
.Bug fixes
no-unsupported-features
aboutsemver
comparison. (#78)Commits
The new version differs by 14 commits.
5634718
5.0.0
aea8e82
Chore: remove deprecated rule's tests
118a1de
Chore: add note about
require("punycode/")
(fixes #72)cf36e6d
Chore: improve auto-generation script
d4e6bc4
Breaking: remove extraneous check from
no-unpublish-*
(fixes #71)a75c638
New:
no-extraneous-*
rules (refs #71)deb4f55
Fix:
no-unsupported-features
goes wrong on>=7.10.0
(fixes #78)0e487f9
Breaking: update
no-deprecated-api
(fixes #80)3387336
Breaking: update
no-unsupported-features
rule (fixes #79)fdd7877
Chore: add Node.js 8 to CI
fa95be2
Chore: add cache to exists()
ffc7fcb
Chore: refactor with classes.
8f00ebb
Chore: remove object-assign from dependencies
734d2e7
Chore: upgrade dependencies
See the full diff
Not sure how things should work exactly?
There is a collection of frequently asked questions and of course you may always ask my humans.
Your Greenkeeper Bot 🌴