fix integer overflow when parsing Perl-extended named backrefs #246
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This issue comes to us as: https://issues.oss-fuzz.com/issues/42512790
Note that Perl seems to reject the regex better than us, flagging
\k--
as invalid in the first place.We seem to treat
\g
and\k
as literally the same, while Perl doesn't. Perl rejects\g--
as unterminated token.Our code seems to parse
\k-
appropriately, with the assumption that it's a valid synonym for\g
, but then we run into overflow issues when parsing the number generated by the fuzzer which isLONG_MIN
.I'm not going to change the behavior of
\k
here but instead I simply just tried my hand at squashing the overflows.