Skip to content

Conversation

bmagistro
Copy link
Contributor

When compiling with clang 19.1.7 on Alma with -Werror and a number of other flags (we run with most warnings enabled), a number of functions are flagged as overriding a function but not marked with override eg error: 'parse' overrides a member function but is not marked 'override' [-Werror,-Wsuggest-override]. Based on older tickets, the BOOST_OVERRIDE macro was used to address this.

Env:
Alma 9.6
Boost 1.88.0 via cmake
clang 19.1.7

Replaces: #97
While ^^ addressed other issues, to keep scope and review simple, the other issues are not addressed in here.

Resolves: #93

@vprus
Copy link
Collaborator

vprus commented Aug 19, 2025

Thanks for the PR. Would you be willing to modify it to use 'override' directly, without any macros, since there's no point supporting C++03.

@bmagistro
Copy link
Contributor Author

will certainly take a look. this approach was chosen by looking at how it was approached in this/other components

@vprus
Copy link
Collaborator

vprus commented Sep 2, 2025

Thanks for the update, it seems the tests all fail to compile in a single place where a different order of "override" and "cost" is needed.

@bmagistro
Copy link
Contributor Author

sorry for the delay and not catching that one.

@vprus vprus merged commit 5fd2470 into boostorg:develop Sep 12, 2025
45 of 55 checks passed
@vprus
Copy link
Collaborator

vprus commented Sep 12, 2025

Thanks, merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

GCC suggest-override warnings

2 participants