Skip to content

Resolve Issue #483 #484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Conversation

AlrondPrime
Copy link

Add support of std::initializer_list<string_view> for windows::default_launcher::operator()

Add support of std::initializer_list<string_view> for windows::default_launcher::operator()
@AlrondPrime
Copy link
Author

The pipeline failed due to changes made around April 14 in the file include\boost\process\v2\stdio.hpp that are incompatible with Windows. Should I fix the errors in this file, or would it be better to fork from another commit and attempt to merge the code there?

@klemens-morgenstern
Copy link
Collaborator

You can add it to this PR if you want

@AlrondPrime
Copy link
Author

I’d prefer to focus on the changes I’ve already made, which are unrelated to the issue in stdio.hpp.
I can help fix the Windows compatibility separately later if needed.

@klemens-morgenstern
Copy link
Collaborator

Ok, I'll see that I find the time this week to properly review this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants