Skip to content

Remove circular dependency on Multiprecision and add CI checks for such occurrences #1333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 30, 2025
Merged

Remove circular dependency on Multiprecision and add CI checks for such occurrences #1333

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cca52ce
Remove multiprecision header leading to circular dependency
mborland Oct 30, 2025
0321de7
Add CI checks for circular dependencies
mborland Oct 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ jobs:
run: cp -r $GITHUB_WORKSPACE/* libs/math
working-directory: ../boost-root
- name: Install deps
run: python tools/boostdep/depinst/depinst.py math -I example -I tools
run: python tools/boostdep/depinst/depinst.py math -C -I example -I tools
working-directory: ../boost-root
- name: Bootstrap
run: ./bootstrap.sh
Expand Down Expand Up @@ -116,7 +116,7 @@ jobs:
run: cp -r $GITHUB_WORKSPACE/* libs/math
working-directory: ../boost-root
- name: Install deps
run: python tools/boostdep/depinst/depinst.py math -I example -I tools
run: python tools/boostdep/depinst/depinst.py math -C -I example -I tools
working-directory: ../boost-root
- name: Bootstrap
run: ./bootstrap.sh
Expand Down Expand Up @@ -157,7 +157,7 @@ jobs:
run: cp -r $GITHUB_WORKSPACE/* libs/math
working-directory: ../boost-root
- name: Install deps
run: python tools/boostdep/depinst/depinst.py math -I example -I tools
run: python tools/boostdep/depinst/depinst.py math -C -I example -I tools
working-directory: ../boost-root
- name: Bootstrap
run: ./bootstrap.sh
Expand Down Expand Up @@ -200,7 +200,7 @@ jobs:
run: xcopy /s /e /q %GITHUB_WORKSPACE% libs\math
working-directory: ../boost-root
- name: Install deps
run: python tools/boostdep/depinst/depinst.py math -I example -I tools
run: python tools/boostdep/depinst/depinst.py math -C -I example -I tools
working-directory: ../boost-root
- name: Bootstrap
run: bootstrap
Expand Down Expand Up @@ -243,7 +243,7 @@ jobs:
run: xcopy /s /e /q %GITHUB_WORKSPACE% libs\math
working-directory: ../boost-root
- name: Install deps
run: python tools/boostdep/depinst/depinst.py math -I example -I tools
run: python tools/boostdep/depinst/depinst.py math -C -I example -I tools
working-directory: ../boost-root
- name: Bootstrap
run: bootstrap
Expand Down Expand Up @@ -287,7 +287,7 @@ jobs:
- name: Copy files
run: C:\\tools\\cygwin\\bin\\bash -l -c 'cd $(cygpath -u "$GITHUB_WORKSPACE") && cp -r * ../boost-root/libs/math'
- name: Install deps
run: C:\\tools\\cygwin\\bin\\bash -l -c 'cd $(cygpath -u "$GITHUB_WORKSPACE")/../boost-root && python tools/boostdep/depinst/depinst.py math -I example -I tools'
run: C:\\tools\\cygwin\\bin\\bash -l -c 'cd $(cygpath -u "$GITHUB_WORKSPACE")/../boost-root && python tools/boostdep/depinst/depinst.py math -C -I example -I tools'
- name: Bootstrap
run: C:\\tools\\cygwin\\bin\\bash -l -c 'cd $(cygpath -u "$GITHUB_WORKSPACE")/../boost-root && ./bootstrap.sh'
- name: Generate headers
Expand Down Expand Up @@ -417,7 +417,7 @@ jobs:
run: cp -r $GITHUB_WORKSPACE/* libs/math
working-directory: ../boost-root
- name: Install deps
run: python tools/boostdep/depinst/depinst.py math -I example -I tools
run: python tools/boostdep/depinst/depinst.py math -C -I example -I tools
working-directory: ../boost-root
- name: Bootstrap
run: ./bootstrap.sh
Expand Down
2 changes: 1 addition & 1 deletion include/boost/math/differentiation/detail/reverse_mode_autodiff_erf_overloads.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@

#include <boost/math/differentiation/detail/reverse_mode_autodiff_utilities.hpp>
#include <boost/math/special_functions/erf.hpp>
#include <boost/multiprecision/cpp_bin_float.hpp>

namespace boost {
namespace math {
namespace differentiation {
Expand Down