Fix several strategies (add getters, fix compilation error and warning) #1364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
include/boost/geometry/strategies/spherical/distance_cross_track_box_box.hpp
Outdated
Show resolved
Hide resolved
barendgehrels
approved these changes
Jan 11, 2025
include/boost/geometry/strategies/geographic/distance_cross_track.hpp
Outdated
Show resolved
Hide resolved
awulkiew
force-pushed
the
fix/strategies
branch
from
2c9cbf8 to
b768c8d
Compare
|
I added one more fix in geo distance_cross_track_box_box strategy. |
include/boost/geometry/strategies/spherical/distance_cross_track_box_box.hpp
Show resolved
Hide resolved
|
I do not know if it makes sense to switch to commit messages as proposed in #1324, now we have a mix of commit messages. |
in sph distance_cross_track_box_box
awulkiew
force-pushed
the
fix/strategies
branch
from
653430a to
c661868
Compare
|
I missed that and used the old pattern. I altered the commit messages. It would probably be useful to have it written down in the gudelines. I can see there are some differences between your messages and the article as well, e.g. doc vs docs, ext vs extension, starting from small vs big letter, etc. Also kinds/categories of changes are mixed with library parts like fix/feat vs extension. Fix/feat should probably be used for extensions as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The getters are missing for
centroidandclosest_pointsinindexand global umbrella strategies preventing them to be passed to these algorithms and rtree.I divided centroid into detail part and official part derived from base. It works for now because centroid doesn't have proper strategies for spherical and geographic. After they are added and e.g. geographic one uses
FormulaandSpheroidwe'll probably have to implement this differently.