[#25] 사용자가이드 단계 이동시 헤더 내 모든 요소 리렌더링 개선 #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chichoc
requested review from
lee0jae330 and
inhachoi
and removed request for
a team
lee0jae330
approved these changes
Jan 24, 2025
inhachoi
approved these changes
Jan 24, 2025
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 #25
🙋 Summary (요약)
😎 Description (변경사항)
사용자 가이드 단계 이동시 해당 단계와 관계없는 요소들이 리렌더링되고 있다.
헤더부분 리렌더링 개선된 결과는 다음과 같다.
헤더쪽 테두리는 헤더가 아닌 workspacePage가 리렌더링되어 보여지는 것이다.
컴포넌트 분리 및 메모이제이션
워크스페이스 헤더 리렌더링 개선
🔥 Trouble Shooting (해결된 문제 및 해결 과정)
🤔 Open Problem (미해결된 문제 혹은 고민사항)
CssPropsSelectBox와 PreviewBox 리렌더링은 아직 개선하지 못했습니다.
#35 머지되면 다시 체크해보겠습니다.