Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOTFIX] cicd 및 docker-compose 코드 수정 #29

Merged
merged 8 commits into from
Jan 21, 2025
Merged

Conversation

Honghyeonji
Copy link
Contributor

@Honghyeonji Honghyeonji commented Jan 21, 2025

🔗 #28

🙋‍ Summary (요약)

  • cicd deploy 과정에서 생긴 오류 수정

😎 Description (변경사항)

cicd deploy 과정에서 생긴 오류 수정

  • dev로 합쳐진 후 실행된 cicd deploy 과정에서 아래와 같은 오류가 발생했습니다.
    image
// 이전 코드
    image: ${DOCKERHUB_USERNAME}/boolock_client_${TYPE}:latest
    pull_policy: always
    ports:
      - '80:80'
      - "${TYPE:-} == 'prod' ? '443:443' : ''"
  • docker-compose.yml 파일을 prod/test버전을 나누지 않고 env 설정에 따라 개방할 port를 달리해주려고 했으나, compose파일에서 삼항연산자가 되지 않는다는 것이었습니다.
  • docker-compose.yml 파일을 prod/test버전으로 나누고 cicd 액션때 달리 사용되게 수정하였습니다.

🔥 Trouble Shooting (해결된 문제 및 해결 과정)

🤔 Open Problem (미해결된 문제 혹은 고민사항)

@Honghyeonji Honghyeonji linked an issue Jan 21, 2025 that may be closed by this pull request
2 tasks
@Honghyeonji Honghyeonji self-assigned this Jan 21, 2025
@Honghyeonji Honghyeonji added bug 버그 CICD 배포 labels Jan 21, 2025
@Honghyeonji Honghyeonji marked this pull request as ready for review January 21, 2025 05:26
@Honghyeonji Honghyeonji requested a review from a team as a code owner January 21, 2025 05:26
@Honghyeonji Honghyeonji requested review from lee0jae330 and inhachoi and removed request for a team January 21, 2025 05:26
@Honghyeonji Honghyeonji merged commit e62079f into dev Jan 21, 2025
4 of 5 checks passed
@Honghyeonji Honghyeonji deleted the HOTFIX/28 branch January 22, 2025 04:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 버그 CICD 배포
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[HOTFIX] cicd 코드 오류 수정
1 participant