[Test] Presentation ViewModel 테스트 #187
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hansangjin98
reviewed
Dec 6, 2024
Comment on lines
+12
to
+15
| final class MockDiaryUseCase: DiaryUseCase { | ||
| var diaryRepository: DiaryRepository { | ||
| fatalError("Not implemented") | ||
| } |
There was a problem hiding this comment.
-
DiaryUseCase에서는 diaryRepository의 함수를 호출하는 로직이 대부분인데 diaryRepository에 접근하면 fatalError를 발생시키는 이유가 있나요? diaryRepository를 주입받거나 호출하는 부분 또한 보이지 않네요
-
실제로 사용되는 DiaryUseCase 구현체에서는 내부에 복잡한 비즈니스 로직들이 존재하는데 해당 비즈니스 로직은 테스트하지 않아도 되나요? 단순 CallCount만 체크하면 되는 로직이 아닌 것 같다는 생각이 듭니다.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 관련 이슈 번호
📘 작업 유형
📙 작업 내역 (구현 내용 및 작업 내역을 기재합니다.)
📝 특이 사항 (Optional)
이전 PR에 이어서 작업한 내용입니다.
ViewModel만의 테스트를 위해, Mock UseCase까지 제작을 한 뒤 테스트를 진행했습니다.
실제 비동기 처리를 대신하기 위해
try await Task.sleep(nanoseconds: 100_000_000)를 사용했습니다.