Optimizer merge #30
Closed
Optimizer merge #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
우선, 다른 팀원들의 작업을 위하여 confirm merge를 하지만 rouge score에 대한 전반적인 변수명 수정 후 다시 pull-request 부탁 드립니다.
gistarrr
reviewed
Dec 8, 2021
quantization.py
Outdated
| check_point=args.check_point, | ||
| test_dataset=args.test_dataset, | ||
| test_dataset_size=args.test_dataset_size, | ||
| cpu_flag=args.cpu_flag, |
There was a problem hiding this comment.
아래의 경우에는 cpu_flag는 따로 없는 것 같은데 half_quantization함수를 보면 test가 True일 때 cpu_flag = True로 설정하시는데 이 인자가 왜 필요한 건지 모르겠습니다.
| test_categories=args.test_categories, | ||
| test= args.no_test_flag, | ||
| ) | ||
| elif args.quantization_type == 'dynamic_quantization': |
There was a problem hiding this comment.
위 경우와 마찬가지로 cpu_flag는 test가 True이면 항상 True로 performance_test 함수에 들어가는데 두 경우를 왜 나누신 건지 모르겠습니다. 코드 상으로 보면 똑같이 동작하지 않을까요?
| return {"time_avg_ms": time_avg_ms, "time_std_ms": time_std_ms} | ||
|
|
||
|
|
||
| def run_benchmark(self): |
There was a problem hiding this comment.
Class 내에 정의되어 있는 함수인데 다른 곳에서 쓰이지는 않는 것 같습니다. 정의한 이유가 있을까요?
There was a problem hiding this comment.
ipynb에서 각각의 compute함수를 사용하기 번거로울때 쓰려고 만들어 뒀습니다.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#29
opimization기법