Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[iOS] 이벤트가 발생할 NowPlaying 관련 기능 구현 #348 #365

Merged
merged 10 commits into from
Dec 10, 2020
Merged

[iOS] 이벤트가 발생할 NowPlaying 관련 기능 구현 #348 #365

merged 10 commits into from
Dec 10, 2020

Conversation

Sueaty
Copy link
Collaborator

@Sueaty Sueaty commented Dec 10, 2020

📕 Issue Number

#348

📙 작업 내역

구현 내용 및 작업 했던 내역

  • 가사보기, 메뉴보기와 now playing 연결
  • 좋아요/좋아요 해제
  • 다중 선택을 통해 now paying 목록에서 제거

📘 작업 유형

  • 신규 기능 추가

📋 체크리스트

  • Merge 하는 브랜치가 올바른가?
  • 코딩컨벤션을 준수하는가?
  • PR과 관련없는 변경사항이 없는가?
  • 내 코드에 대한 자기 검토가 되었는가?
  • 변경사항이 효과적이거나 동작이 작동한다는 것을 보증하는 테스트를 추가하였는가?
  • 새로운 테스트와 기존의 테스트가 변경사항에 대해 만족하는가?

@Sueaty Sueaty added enhancement New feature or request iOS🍎 iOS labels Dec 10, 2020
@Sueaty Sueaty added this to the iOS 4주차 milestone Dec 10, 2020
@Sueaty Sueaty requested a review from TTOzzi December 10, 2020 01:18
@Sueaty Sueaty self-assigned this Dec 10, 2020
TTOzzi
TTOzzi reviewed Dec 10, 2020
View reviewed changes
MiniVibe/MiniVibe/Models/NowPlaying.swift Outdated Show resolved Hide resolved
MiniVibe/MiniVibe/Models/NowPlaying.swift Show resolved Hide resolved
MiniVibe/MiniVibe/Models/UseCases/TrackUseCase.swift Outdated Show resolved Hide resolved
MiniVibe/MiniVibe/Models/Utils/NetworkService.swift Outdated Show resolved Hide resolved
MiniVibe/MiniVibe/Models/Utils/NetworkService.swift Outdated Show resolved Hide resolved
MiniVibe/MiniVibe/ViewModels/TodayViewModel.swift Show resolved Hide resolved
@TTOzzi TTOzzi merged commit 67a4dba into dev Dec 10, 2020
@TTOzzi TTOzzi deleted the feat/NowPlaying-iOS branch December 20, 2020 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TTOzzi TTOzzi TTOzzi left review comments

Assignees

@Sueaty Sueaty

Labels
enhancement New feature or request iOS🍎 iOS
Projects
None yet
Milestone
iOS 4주차
Development

Successfully merging this pull request may close these issues.
2 participants
@Sueaty @TTOzzi