Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update scijava version to 30.0.0 #282

Closed
mdoube opened this issue Feb 5, 2021 · 3 comments
Closed

Update scijava version to 30.0.0 #282

mdoube opened this issue Feb 5, 2021 · 3 comments
Assignees

Comments

@mdoube
Copy link
Member

mdoube commented Feb 5, 2021

Describe the bug
BoneJ is using scijava v. 29.2.1 but 30.0.0 is current

The updater script is complaining...

@mdoube mdoube self-assigned this Feb 5, 2021
@mdoube
Copy link
Member Author

mdoube commented Feb 5, 2021

Tests fail, IIRC this is likely to be in the way the test data maker generates the data or the way the tests check the dimensions. In the past this was resolved only by removing tests.

[ERROR] Tests run: 18, Failures: 4, Errors: 0, Skipped: 0, Time elapsed: 0.978 s <<< FAILURE! - in org.bonej.wrapperPlugins.AnalyseSkeletonWrapperTest
[ERROR] testIntensityImageChannelsCancelPlugin(org.bonej.wrapperPlugins.AnalyseSkeletonWrapperTest)  Time elapsed: 0.043 s  <<< FAILURE!
org.junit.ComparisonFailure: expected:<[The intensity image can't have a channel dimension]> but was:<[An error occurred while opening the image]>
	at org.bonej.wrapperPlugins.AnalyseSkeletonWrapperTest.testIntensityImageChannelsCancelPlugin(AnalyseSkeletonWrapperTest.java:188)

[ERROR] testIntensityImageFramesCancelPlugin(org.bonej.wrapperPlugins.AnalyseSkeletonWrapperTest)  Time elapsed: 0.024 s  <<< FAILURE!
org.junit.ComparisonFailure: expected:<[The intensity image can't have a time dimension]> but was:<[An error occurred while opening the image]>
	at org.bonej.wrapperPlugins.AnalyseSkeletonWrapperTest.testIntensityImageFramesCancelPlugin(AnalyseSkeletonWrapperTest.java:206)

[ERROR] testIntensityImageMismatchingDimensionsCancelPlugin(org.bonej.wrapperPlugins.AnalyseSkeletonWrapperTest)  Time elapsed: 0.035 s  <<< FAILURE!
org.junit.ComparisonFailure: expected:<[The intensity image should match the dimensionality of the input] image> but was:<[An error occurred while opening the] image>
	at org.bonej.wrapperPlugins.AnalyseSkeletonWrapperTest.testIntensityImageMismatchingDimensionsCancelPlugin(AnalyseSkeletonWrapperTest.java:226)

[ERROR] testNot8BitIntensityImageCancelsPlugin(org.bonej.wrapperPlugins.AnalyseSkeletonWrapperTest)  Time elapsed: 0.018 s  <<< FAILURE!
org.junit.ComparisonFailure: expected:<[The intensity image needs to be 8-bit greyscal]e> but was:<[An error occurred while opening the imag]e>
	at org.bonej.wrapperPlugins.AnalyseSkeletonWrapperTest.testNot8BitIntensityImageCancelsPlugin(AnalyseSkeletonWrapperTest.java:293)

@mdoube mdoube added the bug label Feb 5, 2021
@alessandrofelder
Copy link
Member

Agreed, it's the way the test data is created in the tests that causes these failures, similar to #275. One way forward that I'd be happy with would be to document these failures in #275 or a separate issue, and remove the tests for now?

@mdoube
Copy link
Member Author

mdoube commented Jun 16, 2022

Scijava was updated in #311 to 31.1.0

@mdoube mdoube closed this as completed Jun 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants