Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test Failure FractalDimensionWrapperTest #229

Open
mdoube opened this issue Apr 8, 2020 · 3 comments
Open

Test Failure FractalDimensionWrapperTest #229

mdoube opened this issue Apr 8, 2020 · 3 comments
Assignees
@rimadoma

Comments

@mdoube
Copy link
Member

mdoube commented Apr 8, 2020 •
edited
Loading

Describe the bug
On 35cac4e mvn test -P allTests dies, complaining:

[ERROR] Failures: 
[ERROR]   FractalDimensionWrapperTest.testPointResults:116 Incorrect log(count) value expected:<2.0794415416798357> but was:<1.791759469228055>
[ERROR]   FractalDimensionWrapperTest.testResults:151->lambda$testResults$4:151 Fractal dimension column has a wrong value expected:<1.4999999999999998> but was:<1.2924812503605778>
[INFO]
@rimadoma
Copy link
Contributor

rimadoma commented Apr 8, 2020

I'm unable to reproduce. I've long been aware of these "slow tests" randomly failing at times (different tests at different times), but I haven't been able to pinpoint the reason. That's partly why they're not run as part of the normal mvn test cycle. Furthermore these random failures seem to happen when the tests are run from Maven, not when they're launched from an IDE.

@mdoube
Copy link
Member Author

mdoube commented Apr 9, 2020

I'm unable to reproduce.

Me too, on my laptop. Seems to happen only on my workstation. Closing.

@mdoube mdoube closed this as completed Apr 9, 2020
mdoube added a commit that referenced this issue Oct 29, 2020
@mdoube
Reinstate fractal dimension wrapper tests. See issue #229
4bc1bd5 
Sometimes these tests pass and sometimes they fail, but no-one knows
why the result is variable.
mdoube added a commit that referenced this issue Nov 13, 2020
@mdoube @alessandrofelder
Dependency updates (#274)
fd1c3fd 
* Update Eclipse Collections to 10.4.0

* Update scijava to 29.2.1

Hack around some downstream effects:
- change in API for formatService.getFormat
- Tests fail due to malformed calls
These commented-out tests may need reworking in the future.

Remove explicit versions of things included/referred to in scijava >= 29

* Remove com.miglayout from and LocalThickness version from pom.xml

* Comment out some failing tests for later investigation

These seem to be breaking due to API changes in scijava 29

* Remove the Eclipse Collections version declaration

Use whatever version is being declared upstream by scijava

* Reinstate fractal dimension wrapper tests. See issue #229

Sometimes these tests pass and sometimes they fail, but no-one knows
why the result is variable.

* Remove test that checks for an image with a single zero dimension

Zero dimension images are prevented from being created upstream, so this
test has no effect.

* Restore commented-out test

An error was being thrown that does not affect the test run or its
outcome. See scifio/scifio#443

* remove this test for now

Co-authored-by: alessandrofelder <[email protected]>
This was referenced Aug 13, 2021
Closed
Merged
@mdoube mdoube reopened this Aug 16, 2021
@mdoube
Copy link
Member Author

mdoube commented Aug 16, 2021

This bug has come back from the dead once the Thread zombies were killed
imagej/imagej-ops#638

mdoube added a commit that referenced this issue Apr 5, 2024
@mdoube @alessandrofelder
Dependency updates (#274)
e3551e2 
* Update Eclipse Collections to 10.4.0

* Update scijava to 29.2.1

Hack around some downstream effects:
- change in API for formatService.getFormat
- Tests fail due to malformed calls
These commented-out tests may need reworking in the future.

Remove explicit versions of things included/referred to in scijava >= 29

* Remove com.miglayout from and LocalThickness version from pom.xml

* Comment out some failing tests for later investigation

These seem to be breaking due to API changes in scijava 29

* Remove the Eclipse Collections version declaration

Use whatever version is being declared upstream by scijava

* Reinstate fractal dimension wrapper tests. See issue #229

Sometimes these tests pass and sometimes they fail, but no-one knows
why the result is variable.

* Remove test that checks for an image with a single zero dimension

Zero dimension images are prevented from being created upstream, so this
test has no effect.

* Restore commented-out test

An error was being thrown that does not affect the test run or its
outcome. See scifio/scifio#443

* remove this test for now

Co-authored-by: alessandrofelder <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rimadoma rimadoma

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mdoube @rimadoma