Skip to content

feat(core+prompts): Add suggestion + path prompt #314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 14, 2025

Conversation

MacFJA
Copy link
Contributor

@MacFJA MacFJA commented May 10, 2025

Add two new prompts:

path prompt is a specialized version of suggestion prompt (<=> The function that generate the suggestion list is predefined)

Copy link

changeset-bot bot commented May 10, 2025

🦋 Changeset detected

Latest commit: 668e21f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@clack/prompts Minor
@clack/core Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

pkg-pr-new bot commented May 10, 2025

@example/basic@example/changesets

npm i https://pkg.pr.new/bombshell-dev/clack/@clack/core@314
npm i https://pkg.pr.new/bombshell-dev/clack/@clack/prompts@314

commit: 668e21f

Copy link
Member

@dreyfus92 dreyfus92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @MacFJA, this looks pretty cool, but I would like to see some tests for this 😁

@MacFJA
Copy link
Contributor Author

MacFJA commented May 10, 2025

Hey @MacFJA, this looks pretty cool, but I would like to see some tests for this 😁

Added unit tests for core.

prompt will follow soon

@MacFJA
Copy link
Contributor Author

MacFJA commented May 11, 2025

Hey @MacFJA, this looks pretty cool, but I would like to see some tests for this 😁

Added unit tests for core.

prompt will follow soon

@dreyfus92 I added unit test in both core and prompts

@MacFJA MacFJA requested review from dreyfus92 May 14, 2025 13:37
Copy link
Member

@dreyfus92 dreyfus92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @MacFJA, LGTM 😁

@dreyfus92 dreyfus92 merged commit 2837845 into bombshell-dev:main May 14, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Request] Path input
2 participants