Skip to content

core rework/simplification #308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 28, 2025
Merged

Conversation

43081j
Copy link
Collaborator

@43081j 43081j commented Apr 28, 2025

This is a bunch of refactoring on top of the autocomplete prompt which uncovered a whole bunch of possible bugs/awkward code we could fix.

Copy link

changeset-bot bot commented Apr 28, 2025

⚠️ No Changeset found

Latest commit: c1a91d5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

pkg-pr-new bot commented Apr 28, 2025

@example/basic@example/changesets

npm i https://pkg.pr.new/bombshell-dev/clack/@clack/core@308
npm i https://pkg.pr.new/bombshell-dev/clack/@clack/prompts@308

commit: 588d0de

Copy link
Member

@dreyfus92 dreyfus92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is so good, thank you @43081j

@dreyfus92 dreyfus92 merged commit 9b1ebc5 into feat/autocomplete Apr 28, 2025
5 checks passed
@dreyfus92 dreyfus92 deleted the autocomplete-rework branch April 28, 2025 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants