Skip to content

feat(prompts): Add progressbar #290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 16, 2025
Merged

Conversation

MacFJA
Copy link
Contributor

@MacFJA MacFJA commented Apr 14, 2025

Add a new prompt: progress

It's a superset of spinner.

The progress bar came in 3 flavor:

  • block (Unicode: , ASCII: #)
  • heavy (Unicode: , ASCII: =) [default value]
  • light (Unicode: , ASCII: -)

The color scheme is the same as the spinner (fill part is magenta, missing part is dim)

Copy link

changeset-bot bot commented Apr 14, 2025

🦋 Changeset detected

Latest commit: 71792d2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@clack/prompts Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

pkg-pr-new bot commented Apr 14, 2025

@example/basic@example/changesets

npm i https://pkg.pr.new/bombshell-dev/clack/@clack/core@290
npm i https://pkg.pr.new/bombshell-dev/clack/@clack/prompts@290

commit: 71792d2

@43081j
Copy link
Collaborator

43081j commented Apr 15, 2025

I'm also so sorry but I merged a slightly hefty re-organisation of the prompts sources

if you ignore all conflicts and just move your new code to a progress-bar.ts, you should be ok. and add an export to the index

@MacFJA MacFJA force-pushed the feat/progress branch 2 times, most recently from 828fa9b to 95bebfb Compare April 16, 2025 12:46
@43081j
Copy link
Collaborator

43081j commented Apr 16, 2025

looks good to me!

can you add a changeset? i normally just run npx changeset

Copy link
Member

@dreyfus92 dreyfus92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you both! Feel free to merge it @43081j 🫡

@43081j 43081j merged commit 9a09318 into bombshell-dev:main Apr 16, 2025
5 checks passed
@MacFJA MacFJA deleted the feat/progress branch April 16, 2025 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants