Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code update for 2024-01 #301

Merged
merged 1 commit into from
Aug 9, 2024
Merged

Code update for 2024-01 #301

merged 1 commit into from
Aug 9, 2024

Conversation

deepsidhu1313
Copy link

@deepsidhu1313 deepsidhu1313 commented Jul 22, 2024

  • Added Currency and UpdatedAt properties in UsageCharge
  • Removed Deprecated fields accepts_marketing and accepts_marketing_updated_at from customer object
  • Exporting OrderFinancialStatus and OrderFulfillmentStatus from Order

BoldBrandonM
BoldBrandonM previously approved these changes Jul 22, 2024
@deepsidhu1313 deepsidhu1313 changed the title Added Missing properties in UsageCharge Object Code update for 2024-01 Jul 23, 2024
@oliver006
Copy link
Collaborator

Hey there! What's up with all the pre-releases @deepsidhu1313 ?

PS: nice seeing some bold-commerce faces, what's up guys? It's been a while!

@deepsidhu1313
Copy link
Author

Hey there! What's up with all the pre-releases @deepsidhu1313 ?

PS: nice seeing some bold-commerce faces, what's up guys? It's been a while!

Hi, we are updating this library for one of our service, and we are using pre-releases to do some testing on local and staging instead of making final release on this repo.

@oliver006
Copy link
Collaborator

@deepsidhu1313 - want to get this RFR so we can get it merged?

* Added Currency and UpdatedAt properties
* Removed Deprecated fields accepts_marketing and accepts_marketing_updated_at from customer object
* Exporting OrderFinancialStatus and OrderFulfillmentStatus from Order
@deepsidhu1313
Copy link
Author

@oliver006 code is ready for release.

  • Team has tested changes on staging
  • Changes have been made to fix the issue that was found.

Copy link
Collaborator

@oliver006 oliver006 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@oliver006 oliver006 merged commit a609e5a into master Aug 9, 2024
9 checks passed
@oliver006 oliver006 deleted the update_usage_charge branch August 9, 2024 17:16
@oliver006
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants