[INTER-3577] Fix undefined shipping address issue

bold-commerce · May 17, 2024 · a8813a5 · a8813a5
1 parent 9918b1d
commit a8813a5
Show file tree

Hide file tree

Showing 3 changed files with 19 additions and 3 deletions.
diff --git a/src/fastlane/fastlane.ts b/src/fastlane/fastlane.ts
@@ -82,7 +82,7 @@ export default class Fastlane {
             profileData: {
                 card: resp.profileData.card,
                 name: resp.profileData.name,
-                shippingAddress: this.transformPaypalAddress(paypalAddress),
+                shippingAddress: paypalAddress === undefined ? undefined : this.transformPaypalAddress(paypalAddress),
             },
         };
     }

diff --git a/src/types/fastlane.ts b/src/types/fastlane.ts
@@ -74,7 +74,7 @@ export interface IFastlaneAuthenticatedCustomerResult {
             firstName: string;
             lastName: string;
         };
-        shippingAddress: IFastlaneAddress;
+        shippingAddress: IFastlaneAddress | undefined;
         card: IFastlanePaymentToken;
       }
 }

diff --git a/tests/fastlane/fastlane.test.ts b/tests/fastlane/fastlane.test.ts
@@ -1,4 +1,5 @@
 import Fastlane from 'src/fastlane/fastlane';
+import { IFastlaneAuthenticatedCustomerResult } from 'src';
 
 describe('testing Fastlane class', () => {
     const fastlaneInstanceMock = {
@@ -91,6 +92,7 @@ describe('testing Fastlane class', () => {
 
     test.each([
         {
+            name: 'ppcp',
             type: 'ppcp',
             respProfileData: {
                 card: {},
@@ -133,6 +135,20 @@ describe('testing Fastlane class', () => {
             }),
         } as const,
         {
+            name: 'ppcp - no shipping address',
+            type: 'ppcp',
+            respProfileData: {
+                card: {},
+                name: {
+                    firstName: 'firstName',
+                    lastName: 'firstName',
+                },
+                shippingAddress: undefined,
+            },
+            expected: (): IFastlaneAuthenticatedCustomerResult['profileData']['shippingAddress'] => undefined,
+        } as const,
+        {
+            name: 'braintree',
             type: 'braintree',
             respProfileData: {
                 card: {},
@@ -157,7 +173,7 @@ describe('testing Fastlane class', () => {
                 return this.respProfileData.shippingAddress;
             },
         } as const,
-    ])('$type triggerAuthenticationFlow', async (input) => {
+    ])('$name triggerAuthenticationFlow', async (input) => {
         // Arranging
         fastlaneInstanceMock.identity.triggerAuthenticationFlow.mockResolvedValue({
             authenticationState: 'succeeded',