Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spring cleaning with multiarch support #123

Merged
merged 37 commits into from
Feb 20, 2019
Merged

Conversation

amotl
Copy link
Contributor

@amotl amotl commented Feb 17, 2019

Hi there,

along the lines of #113, @bogde and @el3ctrician approved the idea of a spring cleaning of this library.

So, we would like to share what we have now: Different pieces of code and suggestions from various people have been incorporated, I will try to add references to the relevant issues on behalf of the next comment to keep this introduction shorter.

As I don't actually have any hardware on my workbench, I am humbly asking the community (all of you ;]) about whether you would like to give the revamped library a testdrive on a real iron? I will be happy to receive any feedback about the outcome.

While we are discussing this topic at [1], the work-in-progress branch is located at [2] and might receive further updates as we go. We hope you like it.

With kind regards,
Andreas.

[1] https://community.hiveeyes.org/t/improving-the-canonical-hx711-library-for-arduino/539
[2] https://github.com/hiveeyes/HX711/tree/spring-cleaning

@amotl
Copy link
Contributor Author

amotl commented Feb 17, 2019

This actually bundles many suggestions floating around here since quite some time. We hope to have assembled them carefully into something which will be more useful for the community again by making people struggle less when starting with this library on more contemporary and powerful MCUs like ESP, SAMD, STM32 and others.

This branch directly incorporates

parts from these pull requests, selected by cherry-picking.

Also, it will probably contain different bits and pieces from issue requests which have not been pulled in using PRs. We tried our best to knit everything together well. Thanks a bunch for your contributions!

and also

most probably addresses all issues people are having with

ESP8266 arch pragma / yield definition woes

ESP8266 constructor initialization freezes

ESP8266 watchdog timer (WDT)

@amotl amotl mentioned this pull request Feb 17, 2019
@amotl
Copy link
Contributor Author

amotl commented Feb 19, 2019

Update

Thank you so much for testing this on real iron. I will update the documentation reflecting your findings.

I've just updated the README to accordingly. Thanks again.

Also, we've added some things coming from #125 to work on giving users more choice on whether to wait for the HX711 chip or not when initializing the hardware.

to use constants for digital pins at all
Makefile Show resolved Hide resolved
@bogde bogde merged commit c7a7336 into bogde:master Feb 20, 2019
@amotl
Copy link
Contributor Author

amotl commented Feb 20, 2019

Thanks for merging, @bogde. It was a pleasure.

@ClemensGruber
Copy link

I tested the lib succesful with an:

  • Adafruit HUZZAH ESP8266
  • Heltec WiFi Kit 32 (ESP32)
  • Adafruit Feather HUZZAH32 (ESP32)

@amotl
Copy link
Contributor Author

amotl commented Feb 23, 2019

Thanks for testing on more hardware devices, @ClemensGruber! We just made #127 to account for that.

@amotl
Copy link
Contributor Author

amotl commented Mar 1, 2019

@thiasB also found that

Code is running fine on an Adafruit Feather M0 RFM95 Lora 1 (ATSAMD21G18 Cortex M0) board.

Thanks for testing!

@amotl
Copy link
Contributor Author

amotl commented Mar 4, 2019

While @riemers also confirms more stability with the changes coming from this PR, he reports about random erratic readings when running on ESP8266.

While he outlined his observations at Skaronator/ESP8266-Load-Cell#8 (comment), we might want to open a dedicated issue for that here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants