fix: compile transport_internal_test.go against the klauspost gzip reader - #25
Merged
bogdanfinn merged 1 commit intoSep 2, 2026
Conversation
…ader Since #19 switched response decompression to klauspost/compress, gzipReader.zr is a *klauspost gzip.Reader, but the sentinel in TestGzipReaderUnreadableBodyReturnsReaderToPool (added in #23) is still built with the standard library gzip package, so the package tests no longer compile: transport_internal_test.go:520:17: invalid operation: next.zr == sentinel (mismatched types *"github.com/klauspost/compress/gzip".Reader and *"compress/gzip".Reader) Import the klauspost gzip package in the test instead.
Owner
|
@burruplambert thank you very much. i already fixed that locally after merging your change. But thanks for taking the time and providing a PR for the fix aswell. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Since #19 switched response decompression to klauspost/compress,
gzipReader.zris a*klauspost gzip.Reader. The sentinel inTestGzipReaderUnreadableBodyReturnsReaderToPool(added in #23) is still built with the standard library gzip package, so the two PRs together left the package tests uncompilable on master:One line: import the klauspost gzip package in the test instead. All
TestGzipReader*tests pass again withgo test -run TestGzipReader .